Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L-01, L-02 & L-03 addendum #1929

Merged
merged 2 commits into from
Nov 13, 2023
Merged

L-01, L-02 & L-03 addendum #1929

merged 2 commits into from
Nov 13, 2023

Conversation

sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Nov 13, 2023 •
edited
Loading

  • changes _exactBptInTokensOutIndex & _btpInExactTokensOutIndex to uint8 data type
  • changes RECOVERY_MODE_EXIT_KIND type to uint8
  • adds comment & test regarding duplicate withdrawal with 0 / near 0 amount

@rafaelugolini rafaelugolini temporarily deployed to preview-ousd-sparrowdom-xplgls November 13, 2023 17:52 Inactive
@sparrowDom sparrowDom changed the base branch from master to sparrowDom/balancer-composable-st-pool November 13, 2023 17:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited
Loading

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against ff7c11a

@sparrowDom sparrowDom temporarily deployed to preview-ousd-sparrowdom-xplgls November 13, 2023 18:00 Inactive
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (sparrowDom/balancer-composable-st-pool@7729d17). Click here to learn what that means.
The diff coverage is n/a.

@@                            Coverage Diff                            @@
##             sparrowDom/balancer-composable-st-pool    #1929   +/-   ##
=========================================================================
  Coverage                                          ?   67.88%           
=========================================================================
  Files                                             ?       53           
  Lines                                             ?     2762           
  Branches                                          ?      715           
=========================================================================
  Hits                                              ?     1875           
  Misses                                            ?      884           
  Partials                                          ?        3

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

DanielVF
DanielVF approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@DanielVF DanielVF left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see that the cast to a uint is safe. From the solidity docs:

The explicit conversion from integer checks at runtime that the value lies inside the range of the enum and causes a Panic error otherwise.

Can merge. Will fully verify when integrated. 👍

@sparrowDom sparrowDom merged commit ddbfb4c into sparrowDom/balancer-composable-st-pool Nov 13, 2023
14 of 18 checks passed
@sparrowDom sparrowDom deleted the sparrowDom/balancerAuditFixes branch November 13, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielVF DanielVF DanielVF approved these changes

@naddison36 naddison36 Awaiting requested review from naddison36 naddison36 is a code owner

@shahthepro shahthepro Awaiting requested review from shahthepro shahthepro is a code owner

@smitch88 smitch88 Awaiting requested review from smitch88

@rafaelugolini rafaelugolini Awaiting requested review from rafaelugolini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sparrowDom @DanielVF @rafaelugolini